pkp/pkp-lib#10263 Relax editing metadata on published/posted materials #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-fix
branch
5 times, most recently
from
bc85b26 to
99e1525
Compare
Vitaliy-1
reviewed
Apr 25, 2025
Vitaliy-1
reviewed
Apr 25, 2025
| $this->setReadOnly(true); | ||
| $userRoles = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_USER_ROLES); | ||
| if ( | ||
| !in_array(Role::ROLE_ID_SITE_ADMIN, $userRoles) |
There was a problem hiding this comment.
We can do it here and in other places in one check, e.g, array_intersect?
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-fix
branch
from
99e1525 to
4d661a1
Compare
asmecher
approved these changes
Apr 30, 2025
Hafsa-Naeem
force-pushed
the
i10263-stable_3_5_0-fix
branch
from
a2a4284 to
74b22e9
Compare
Vitaliy-1
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue##10263